search

moleculer-go / moleculer

🚀 Progressive microservices framework for Go - based and compatible with https://github.com/moleculerjs/moleculer
MIT License
144 stars 27 forks source link

AMQ fails intermittently in the CI #76

Open pentateu opened 5 years ago

pentateu commented 5 years ago

@casskir the tests for AMQ fails intermittently in the CI Check: https://cloud.drone.io/moleculer-go/moleculer Builds #400 and #401 failed at different points and #402 passed. No code changes, I just manually restarted the build. So test sometimes pass and sometimes fails. On my local machine passed every-time, so it could be that in the CI server is a bit slower and cause these inconsistencies.

casskir commented 5 years ago

For fix it need to be merge https://github.com/moleculer-go/goemitter/pull/1

pentateu commented 5 years ago

Hi @casskir ,

I have merged the fixes on goemitter, thanks for catching and fixing that. I have also done a PR for the upstream project.

I have updated the go mod to point to the new goemitter version v1.0.2 , but the intermittent issues continue.

passed: https://cloud.drone.io/moleculer-go/moleculer/405/1/4

Failed: https://cloud.drone.io/moleculer-go/moleculer/406/1/4 https://cloud.drone.io/moleculer-go/moleculer/407/1/4

pentateu commented 5 years ago

@casskir if u want to discuss this or anything else --> https://gitter.im/moleculer-go/moleculer

pentateu commented 4 years ago

Tests are failing intermitent after AMQP transit was added. The tests alwasy work when run isolated, but then the whole suit runs fails in the CI frequently. Local machine is rare, but also happens. So it seems that just adjusting the tests can make them robust and solid every time.