search

moleculer-go / moleculer

🚀 Progressive microservices framework for Go - based and compatible with https://github.com/moleculerjs/moleculer
MIT License
144 stars 27 forks source link

fix actions name (added version if exists) #78

Closed vpashka closed 4 years ago

vpashka commented 4 years ago

Hello (again).. During testing, we found the problem of calling functions on services if they have a version specified. Local functions are adding correctly (with the version in the name). But for some reason, the functions of remote services are added without a version in the name.

This patch corrects function names.

P.S. I'm not completely sure that this is the correct fix, but it helped us.

vpashka commented 4 years ago

@pentateu What do you think about this?

pentateu commented 4 years ago

I have to run the tests locally isolated, since the CI is broken at the moment.

The change itself looks fine, but lets test and make sure does not impact on anything else.

pentateu commented 4 years ago

@vpashka I have created branch feat/add_version_action_names where I have tested your change and I have found one issue. The Transit tests were failing, basically any remote call was failing. I have fixed in the branch and tests now works fine, but you should test in your original case/problem to make sure also solves your original problem.

Pull request here: https://github.com/moleculer-go/moleculer/pull/83

If this branch also works for you, let me know in the PR and I can merge and release for you.

Thank again for the support and help.