moleculerjs / moleculer-cli

:herb: Command line tool for Moleculer
http://moleculer.services/docs/moleculer-cli.html
MIT License
48 stars 28 forks source link

Fix for double characters due to inquirer package: #72

Open CodexHere opened 1 year ago

CodexHere commented 1 year ago
icebob commented 1 year ago

This PR contains a lot of breaking changes. Can we upgrade only the non-ESM inquirer 8.x.x? Is it solved the original problem?

AndreMaz commented 1 year ago

I don't think so. This seems to be the source of the problem: https://github.com/SBoudrias/Inquirer.js/issues/109 and I think that this was only solved in v9 of inquirer

CodexHere commented 1 year ago

Ah a few of us had kinda talked about this in the Discord...

As @AndreMaz mentions, this was only fixed after it moved to ESM.

I wasn't sure how the legacy node versions were handled, and I tested down to v16 due to it being the lowest version still not EOL'd (although in 2 months it will be, and it's the lowest version dockerhub has in their registry).

From the minimal error information, it seems like some dependency is failing it's postinstall script while accessing an arbitrary object. async/await was added in node 7.6, so not sure which lib would be dealing with this.

I don't currently have the capacity to build Dockerfiles for v10-14 for node, but might in the near™ future so that I can dive deeper into which dependency is failing

Otherwise, not sure what the course of action is here.

icebob commented 1 year ago

I don't think so. This seems to be the source of the problem: SBoudrias/Inquirer.js#109 and I think that this was only solved in v9 of inquirer

I've checked the issue, but I don't see it's been solved, no any relevant commit linked to the issue, just workarounds in the comments.

AndreMaz commented 1 year ago

You are right, the issue doesn't contain any fix for the issue. However, I've tested locally by bumping inquirer to latest v8.x version and the issue was still present. In this PR the issue is gone

You can reproduce the issue by running npm run dev

CodexHere commented 1 year ago

On that issue the dev says he fixed a bunch of event listeners and it's working. Unfortunately there's no explicit commit to knowingly point to: https://github.com/SBoudrias/Inquirer.js/issues/109#issuecomment-199006633

ImTheDeveloper commented 4 months ago

Came here as I have the double char issue also. Did anything get merged in or a work around? I can see this one is failing some tests now.