search

moleculerjs / moleculer-db

:battery: Database access service mixins for Moleculer
https://moleculer.services/
MIT License
152 stars 123 forks source link

Support moleculer-db-adapter-typeorm #194

Closed guilhermedalleprane closed 4 years ago

guilhermedalleprane commented 4 years ago

Hi, any chance to have moleculer-db-adapter-typeorm incorporated to this repository? It has been inactive for a long time and it seems that it is not accepting pull requests.

As this is the official repository, i think the community could contribute more easily.

Unfortunately, Sequelize not support Oracle and apparently will not do it: https://github.com/sequelize/sequelize/pull/7123#issuecomment-620375692

Therefore, we don't have a good option to use oracle database with moleculerjs. TypeORM would be a good option.

Thanks

icebob commented 4 years ago

If you could help to contribute with this repo, I will pull it. But I have no capacity to learn about typeorm and maintain this adapter, as well.

guilhermedalleprane commented 4 years ago

Of course, I would be happy to help!

icebob commented 4 years ago

Great. In this case, I will try to reach @dkuida to transfer the repo into moleculer organization. If he doesn't reply, I will fork it and place into it.

guilhermedalleprane commented 4 years ago

Hi, @icebob. Sorry for the inconvenience, but... any news about that?

icebob commented 4 years ago

@guicovred Here is the transferred repo: https://github.com/moleculerjs/moleculer-db-adapter-typeorm

icebob commented 4 years ago

@guicovred do you still plan to maintain it?

guilhermedalleprane commented 4 years ago

Hi,

Yes, I consider that the typeorm is an interesting option for the connection with some relational databases so I would like to help to mantain it, unfortunately I'm not having free time for this. At the time of the issue opening, I had a specific need that I ended up solving in another way, so we don’t need to treat this as a priority, if there’s something more interesting to moleculer that I can help with, I’ll be happy to do. Otherwise, in a few months I would look at the typeorm again

guilhermedalleprane commented 4 years ago

@icebob An adapter for typeorm will have some differences, especially when compared to adapters for document-oriented databases.

An example is that in a document-oriented database it is interesting to find a document and then load the "relationships". In relational databases, this is ideally done in a single query, so the populates configuration of the service, although it can be implemented, would probably be slow.

I believe it is better to create a completely separate module, focused only on relational databases, so you can optimize several things. If you don't see any problems with that, I will be doing it and when I have something stable I can transfer the repository to moleculer organization (I will continue helping). What do you think?

Or it wouldn't be a problem to have an adapter that works a little differently or doesn't use all the configurations defined in the moleculer-db module?

icebob commented 4 years ago

Ok, go ahead ;) First of all, try to cover the same functionality as other adapters.

riyaz-incredere commented 1 year ago

Hey @icebob @guilhermedalleprane , Is anyone working on this https://github.com/moleculerjs/moleculer-db-adapter-typeorm ? Or any reference to achieve same thing?

guilhermedalleprane commented 1 year ago

Hey @icebob @guilhermedalleprane , Is anyone working on this https://github.com/moleculerjs/moleculer-db-adapter-typeorm ? Or any reference to achieve same thing?

At the time, I ended up not using it, but as far as I know, this module is fully functional, so only some maintenance is done when necessary. If you need something specific, I suggest opening an issue directly in the repository you linked. I'll be happy to help.