moleculerjs / moleculer-repl

REPL module for Moleculer framework
http://moleculer.services/docs/moleculer-repl.html
MIT License
27 stars 25 forks source link

add match service name with version in filter #40

Closed intech closed 4 years ago

intech commented 4 years ago

Close issue #39

intech commented 4 years ago

One moment, this broken

icebob commented 4 years ago

It's not so easy :P If the version is a Number you should prefix with v.

By the way, as for 0.14, there is a fullName property of services.

icebob commented 4 years ago

Similar code: https://github.com/moleculerjs/moleculer/blob/938662d6b36d6b712d9ddbd14e6bbc275ba30765/src/service.js#L83

intech commented 4 years ago

Similar code: https://github.com/moleculerjs/moleculer/blob/master/src/service.js#L83

Pass to fullName will not breaking change?

icebob commented 4 years ago

Yes, so would be good to check service.fullName != null ? service.fullName : (......)

icebob commented 4 years ago

Could you try it? I've just write here on Github, I don't know it doesn't contain some syntax error.

intech commented 4 years ago

https://repl.it/@IvanZhuravlev/moleculer-createService all ok! Снимок экрана от 2019-12-13 00-40-00