search

moleculerjs / moleculer-repl

REPL module for Moleculer framework
http://moleculer.services/docs/moleculer-repl.html
MIT License
27 stars 25 forks source link

Adds Types #62

Closed AndreMaz closed 2 years ago

AndreMaz commented 2 years ago

Related to: https://github.com/moleculerjs/moleculer/pull/1064

shawnmcknight commented 2 years ago

@AndreMaz I noticed in moleculerjs/moleculer#1068 that the PR author added in some repl options. I took a look back at this PR to see if that was simply a mistake or if they were trying to fix additional things. One thing I noticed here is that the types are stored in a types subfolder, which is fine, but I think the package.json will need a types property pointing to location of the main index.d.ts file based on how TS resolves modules. If it was in the root folder it would resolve automatically, but being in a subfolder I think it will be missed. Let me know if you have any questions on that.

AndreMaz commented 2 years ago

@shawnmcknight Thanks you for pointing this out 😉

Fixed: https://github.com/moleculerjs/moleculer-repl/commit/adb2541ddcdabb9c14bf717a25bc698b509f9e3e