Template improvements - Githubissues

moleculerjs / moleculer-template-project

:mortar_board: Common project template for Moleculer-based projects

MIT License

21 stars 21 forks source link

Template improvements #18

Closed AndreMaz closed 4 years ago

AndreMaz commented 4 years ago

Some template improvements:

Fixed some typos
Fixed questions. The metrics and tracing responses were swapped
Replaced rest: "/hello" with rest: { method: "GET", path: "/hello" }, to show that object declaration is also possible
Added some JSDocs @typedefs to enable some intellisense. It's useful for newcomers.

moleculer-web actually extends the reqand res so it would be good add them to index.d.ts and use them instead of http.IncomingMessage and http.ServerResponse .

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/icebob/moleculer-template-project/jyksjsrerl ✅ Preview: In Progress

icebob commented 4 years ago

I should update the index.html to handler rest object, as well

icebob commented 4 years ago

Thanks!