search

moleculerjs / moleculer-template-project

:mortar_board: Common project template for Moleculer-based projects
MIT License
21 stars 21 forks source link

feature: add hot reload in Dockerfile for use in develop too #30

Closed devalexandre closed 3 years ago

devalexandre commented 3 years ago

In order to be able to use the same environment both in development and in production it is important that developers use the same versions of services, so I believe I have a docker-compose that can be used both in production and in development something crucial

intech commented 3 years ago

I think this is the wrong approach for a shared repository.

In any case, the container requires rebuilding the code or forwarding volume with the code from the host machine, otherwise there is no point in hot reloading.

You can use this template in your tasks from your repository via custom

devalexandre commented 3 years ago

I think this is the wrong approach for a shared repository.

In any case, the container requires rebuilding the code or forwarding volume with the code from the host machine, otherwise there is no point in hot reloading.

You can use this template in your tasks from your repository via custom

yes it makes perfect sense, i sent a done placing the image inside the project so it looks better, i will keep the same image on the dockerhub and put the link here so i keep the travis for testing

icebob commented 3 years ago

This template creates a common minimal project (with minimal docker image). So it's just a basic config, the users should add more details. Your Dockerfile is a custom file for your use-case which is not common and minimal, so I won't merge it. Sry.