moleculerjs / moleculer-web

:earth_africa: Official API Gateway service for Moleculer framework
http://moleculer.services/docs/moleculer-web.html
MIT License
292 stars 119 forks source link

allow set debounceTime #260

Closed 0x0a0d closed 3 years ago

0x0a0d commented 3 years ago

allow to change default 500ms at line 1583, that will be called at line 1529

0x0a0d commented 3 years ago

Hi debounceTime === 0 is same with setTimeout 0 and will be executed on process next tick

On Wed, Jul 21, 2021 at 14:30 Icebob @.***> wrote:

@.**** requested changes on this pull request.


In src/index.js https://github.com/moleculerjs/moleculer-web/pull/260#discussion_r673728695 :

@@ -1580,10 +1583,11 @@ module.exports = {

      this.settings.routes.forEach(route => this.addRoute(route));

  // Regenerate all auto aliases routes
  • const debounceTime = this.settings.debounceTime >= 0 ? parseInt(this.settings.debounceTime) : 500;

this.settings.debounceTime >= 0 is not correct. Just this.settings.debounceTime

0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/moleculerjs/moleculer-web/pull/260#pullrequestreview-711340118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX6SL7YJMKJ5KWAZ2OQZNTTYZZQTANCNFSM5AHYQNUA .

icebob commented 3 years ago

Yeah, just null >= 0 is true, so if somebody set it to null it should be used the default 500 value.

0x0a0d commented 3 years ago

Oh, new knowledge lol

On Wed, Jul 21, 2021 at 14:36 Icebob @.***> wrote:

Yeah, just null >= 0 is true, so if somebody set it to null it should be used the default 500 value.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/moleculerjs/moleculer-web/pull/260#issuecomment-883963144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX6SLY3MYPEIPDFP7F5RW3TYZ2IHANCNFSM5AHYQNUA .