When using middleware for the call method, the call context was lost, as described in #1241 . This issue occurred because the context was passed through the mutation of the promise. Consequently, if the middleware awaited the result from the promise and returned a new promise, the execution context was lost.
In order to maintain backward compatibility, I propose the following solution:
We can wrap the middleware for specific hooks, such as call, in an interceptor function. The interceptor is responsible for setting the context value for the promise that will be returned from the user's middleware.
In this pull request, I have added interceptor functionality to the MiddlewareHandler class, as well as an interceptor method for the call hook in the ServiceBroker class.
:dart: Relevant issues
1241
:gem: Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
:vertical_traffic_light: How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[x] Integration middlware test "Test hook middleware interceptors".
[x] Unit service broker test "Test broker.interceptCallMiddleware".
:checkered_flag: Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have commented my code, particularly in hard-to-understand areas
icebob
commented
8 months ago
:memo: Description
When using middleware for the call method, the call context was lost, as described in #1241 . This issue occurred because the context was passed through the mutation of the promise. Consequently, if the middleware awaited the result from the promise and returned a new promise, the execution context was lost.
In order to maintain backward compatibility, I propose the following solution: We can wrap the middleware for specific hooks, such as call, in an interceptor function. The interceptor is responsible for setting the context value for the promise that will be returned from the user's middleware.
In this pull request, I have added interceptor functionality to the MiddlewareHandler class, as well as an interceptor method for the call hook in the ServiceBroker class.
:dart: Relevant issues
1241
:gem: Type of change
:vertical_traffic_light: How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
:checkered_flag: Checklist: