Fix: add nest prop to Preact types, in line with React types

molefrog / wouter

🥢 A minimalist-friendly ~2.1KB routing for React and Preact

https://npm.im/wouter

The Unlicense

6.41k stars 146 forks source link

Fix: add nest prop to Preact types, in line with React types #426

Closed bensaufley closed 4 months ago

bensaufley commented 4 months ago

Am I wrong that this is just an oversight in the types? The Preact package mostly just imports the React one. I did double-check the rest of the file and everything looks equivalent besides this.

stackblitz[bot] commented 4 months ago

Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f2e3b8d) to head (0a33c88).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## v3 #426 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

molefrog commented 4 months ago

You are right, I've overlooked it. Preact types sometimes become out of date because we lack a good way to build them based on React types. This probably requires some refactoring and a Vite plugin (haven't researched this, but open to contributions).

molefrog commented 4 months ago

Published a bugfix in v3.1.1