molenzwiebel / OriannaBot

:robot: Everyone's favorite Discord bot
MIT License
119 stars 23 forks source link

Add info about required version of Node to README #32

Closed robertgrzonka closed 4 years ago

robertgrzonka commented 4 years ago

Issue

While installing dependencies on ./frontend I get errors (posted at the end).

Steps to investigate

I tried to run yarn on Nodes: v14, v12 and only on v10 installing dependencies was successful.

Why?

I think that this info may be relevant in README.md for potential contributors.

Error output

I won't paste whole because it's too long. Ping me if needed.

Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.6.39
node-pre-gyp info using node@14.3.0 | darwin | x64
node-pre-gyp info check checked for \"/Users/robertgrzonka/Projects/OriannaBot/frontend/node_modules/fsevents/lib/binding/Release/node-v83-darwin-x64/fse.node\" (not found)
node-pre-gyp http GET https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v83-darwin-x64.tar.gz
node-pre-gyp http 404 https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v83-darwin-x64.tar.gz
node-pre-gyp ERR! Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v83-darwin-x64.tar.gz 
node-pre-gyp ERR! Pre-built binaries not found for fsevents@1.1.3 and node@14.3.0 (node-v83 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp http 404 status code downloading tarball https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v83-darwin-x64.tar.gz 
node-pre-gyp ERR! Tried to download(undefined): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v83-darwin-x64.tar.gz 
node-pre-gyp ERR! Pre-built binaries not found for fsevents@1.1.3 and node@14.3.0 (node-v83 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp http Connection closed while downloading tarball file 
gypgyp info it worked if it ends with ok
info it worked if it ends with ok
gyp info using node-gyp@5.1.0
gyp gypinfo info using  node@14.3.0 | darwin | x64

A lot lines of code later:


In file included from ../fsevents.cc:6:
../../nan/nan.h:839:18: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
In file included from     return node::MakeCallback(../fsevents.cc:6
^
:
../../nan/nan.h:839:18: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations]
return node::MakeCallback(
^
/Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:188:1: note: 'MakeCallback' has been explicitly marked deprecated here
NODE_DEPRECATED(\"Use MakeCallback(..., async_context)\",
/Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:^
188:/Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h1::108:20: note: expanded from macro 'NODE_DEPRECATED'
note: 'MakeCallback' has been explicitly marked deprecated here    __attribute__((deprecated(message))) declarator
               ^

NODE_DEPRECATED(\"Use MakeCallback(..., async_context)\", ^ /Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:108:20: note: expanded from macro 'NODE_DEPRECATED' attribute((deprecated(message))) declarator ^ In file included from ../fsevents.cc:6: ../../nan/nan.h:854:18: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations] return node::MakeCallback( ^In file included from ../fsevents.cc:6:

../../nan/nan.h:854:18:/Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:181: warning: 1'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations] : note: return node::MakeCallback( ^ 'MakeCallback' has been explicitly marked deprecated here /Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:181:1: note: 'MakeCallback' has been explicitly marked deprecated here NODE_DEPRECATED(\"Use MakeCallback(..., async_context)\", ^ /Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:108:20: NODE_DEPRECATED(\"Use MakeCallback(..., async_context)\", note: expanded from macro 'NODE_DEPRECATED'^

/Users/robertgrzonka/Library/Caches/node-gyp/14.3.0/include/node/node.h:108:20: note: expanded from macro 'NODE_DEPRECATED' attribute((deprecated(message))) declarator

molenzwiebel commented 4 years ago

Thanks! I should really think about upgrading some dependencies (although technically 10.x is still in maintenance mode until 2021).