Feat/new features + VEP update

molgenis / capice

GNU Lesser General Public License v3.0

23 stars 10 forks source link

Feat/new features + VEP update #137

Closed svandenhoek closed 2 years ago

svandenhoek commented 2 years ago

SOP

Changed

Adjustments to include Grantham/PhyloP.
Updated to newest VEP version used in VIP.
made README more verbose.

Before merge:

[ ] Functionality works & meets specs
[ ] No Travis issues
[ ] Code reviewed
[ ] Documentation was updated

After merge:

[ ] Added feature/fix to draft release notes
[ ] Removed merged branches

svandenhoek commented 2 years ago

I would like to see the internal CAPICE version within ./src/molgenis/capice/__init__.py changed to 4.0.0-rc3 (for the PoC model, you can just unpickle it in a python console and change the CAPICE_version attribute manually to 4.0.0-rc3)

Fixed. The xgb_booster_poc.pickle.dat should now return the following:

>>> import pickle

>>> with open('./tests/resources/xgb_booster_poc.pickle.dat', 'rb') as model_file:
>>>     model = pickle.load(model_file)

>>> model.CAPICE_version
'4.0.0-rc3'

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication