search

molgenis / molgenis-app-biobank-explorer

Vue application for the biobank explorer; A card detail view on BBMRI biobank - collection data
GNU Lesser General Public License v3.0
3 stars 20 forks source link

Biobank Explorer does not support localisation of the buttons #111

Closed esthervanenckevort closed 2 years ago

esthervanenckevort commented 5 years ago

How to Reproduce

Edit the negotiator localisation in MOLGENIS

Expected behaviour

The 'Go to sample / data negotiation' button adopts the new localised string

Observed behaviour

The button does not honour the localised string.

mswertz commented 5 years ago

deeper motivation is that we really would like to be able to change this label.

mswertz commented 5 years ago

I understood this is now fixed, correct? then close please.

mswertz commented 5 years ago

@djvanenckevort I believe that you now can sufficiently confirm label of the button in the data explorer. Am I correct and can we close this one?

esthervanenckevort commented 5 years ago

You can configure it in the Data Explorer, but not in the Biobank Explorer.

fdlk commented 4 years ago

App store apps do not support localization.

If you only need one particular label "localized", I understand that you actually need to customize the existing English label(s) from one deployment to another?

We do support specifying customization options to apps in the freemarker, and we could add this label as an option if you need a quick fix. That would be in the https://github.com/molgenis/molgenis-app-biobank-explorer repository.

In the long run, for localization of proxied Vue apps I'd like to take a look at bundling the translations in the app.

jelmerveen commented 2 years ago

Buttons and links are now editable through the configuration screen.