molgenis / molgenis-app-biobank-explorer

Vue application for the biobank explorer; A card detail view on BBMRI biobank - collection data
GNU Lesser General Public License v3.0
3 stars 20 forks source link

Ux/feedback review 1 20 #410

Closed jelmerveen closed 1 year ago

jelmerveen commented 1 year ago

Checklist

molgenis-jenkins commented 1 year ago

:star: PR Preview available on https://preview-bbmri-pr-410.dev.molgenis.org

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 28.5% and project coverage change: -0.9 :warning:

Comparison is base (9cab226) 74.0% compared to head (b4853ec) 73.2%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #410 +/- ## ======================================== - Coverage 74.0% 73.2% -0.9% ======================================== Files 67 68 +1 Lines 1799 1814 +15 Branches 365 366 +1 ======================================== - Hits 1332 1328 -4 - Misses 453 469 +16 - Partials 14 17 +3 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `73.2% <28.5%> (-0.9%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis) | Coverage Δ | | |---|---|---| | [...s/generators/custom-view-components/FactsTable.vue](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbXBvbmVudHMvZ2VuZXJhdG9ycy9jdXN0b20tdmlldy1jb21wb25lbnRzL0ZhY3RzVGFibGUudnVl) | `0.0% <0.0%> (ø)` | | | [src/config/facetConfigurator.js](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbmZpZy9mYWNldENvbmZpZ3VyYXRvci5qcw==) | `100.0% <ø> (ø)` | | | [src/config/initialFilterFacets.js](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbmZpZy9pbml0aWFsRmlsdGVyRmFjZXRzLmpz) | `100.0% <ø> (ø)` | | | [src/components/filters/ToggleFilter.vue](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbXBvbmVudHMvZmlsdGVycy9Ub2dnbGVGaWx0ZXIudnVl) | `6.6% <6.6%> (ø)` | | | [src/components/ApplicationHeader.vue](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbXBvbmVudHMvQXBwbGljYXRpb25IZWFkZXIudnVl) | `77.7% <100.0%> (+1.5%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

molgenis-jenkins commented 1 year ago

:star: PR Preview available on https://preview-bbmri-pr-410.dev.molgenis.org

molgenis-jenkins commented 1 year ago

:star: PR Preview available on https://preview-bbmri-pr-410.dev.molgenis.org