molgenis / molgenis-app-biobank-explorer

Vue application for the biobank explorer; A card detail view on BBMRI biobank - collection data
GNU Lesser General Public License v3.0
3 stars 20 forks source link

fix: removed flip animation from the cards due to safari breaking it #412

Closed jelmerveen closed 1 year ago

jelmerveen commented 1 year ago

Checklist

molgenis-jenkins commented 1 year ago

:star: PR Preview available on https://preview-bbmri-pr-412.dev.molgenis.org

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (695aa93) 70.9% compared to head (49c2f71) 70.9%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #412 +/- ## ====================================== Coverage 70.9% 70.9% ====================================== Files 77 77 Lines 1897 1897 Branches 371 371 ====================================== Hits 1345 1345 Misses 535 535 Partials 17 17 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `70.9% <100.0%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis) | Coverage Δ | | |---|---|---| | [src/components/cards/BiobankCard.vue](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbXBvbmVudHMvY2FyZHMvQmlvYmFua0NhcmQudnVl) | `92.0% <ø> (ø)` | | | [src/components/generators/view-components/mref.vue](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL2NvbXBvbmVudHMvZ2VuZXJhdG9ycy92aWV3LWNvbXBvbmVudHMvbXJlZi52dWU=) | `100.0% <100.0%> (ø)` | | | [src/utils/templateMapper.js](https://app.codecov.io/gh/molgenis/molgenis-app-biobank-explorer/pull/412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=molgenis#diff-c3JjL3V0aWxzL3RlbXBsYXRlTWFwcGVyLmpz) | `95.8% <100.0%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

molgenis-jenkins commented 1 year ago

:star: PR Preview available on https://preview-bbmri-pr-412.dev.molgenis.org