search

molgenis / molgenis-app-genetics

Repository containing modules and features for interacting with, searching through, and visualising genetic data
GNU Lesser General Public License v3.0
1 stars 4 forks source link

Request to /version path return apps version #44

Open ConnorStroomberg opened 7 years ago

ConnorStroomberg commented 7 years ago

A GET request to the molgenis api at '/api/v2/version' returns the apps version as ( 1.0.0 at the moment). This request used to return the molgenis-platform version ( 4.0.0. at at the moment).

For example at the time of writing a request to the genetics app at

https://molgenis43.gcc.rug.nl/api/v2/version

returns

{"buildDate":"2017-05-19 09:00 UTC","molgenisVersion":"1.0.0-SNAPSHOT"}

The molgenis version in this example points to the app version not the molgenis platform version.

Any application (for example https://github.com/molgenis/molgenis-EMX-downloader )that uses the version number returned by the request may make false assumptions about the molgenis-platformversion ( and emx / api versions).

A possible fix may be to include a seperate app-version-number and have the molgenisVersion version point to the molgenis platform version.

bartcharbon commented 7 years ago

We probably want to return both the app version and the platform version. This issue probably need to be adressed in the platform, I'll add and issue to link to this one in the molgenis repo