search

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
14 stars 18 forks source link

Filtering on network in 'general' variable explorer should (but doesn't) also filter on the cohorts in the harmo matrix #2724

Open EleanorHyde-UMCG opened 1 year ago

EleanorHyde-UMCG commented 1 year ago

What version of EMX2 are you using (see footer) Software version: v8.213.29. Database version: 8.

Describe the bug Filtering on network in 'general' variable explorer should (but doesn't) also filter on the cohorts in the harmo matrix

To Reproduce Steps to reproduce the behavior:

  1. Go to https://data-catalogue-acc.molgeniscloud.org/catalogue/catalogue/#/variable-explorer
  2. See that there are 2197 variables
  3. Search on m_bps in the search bar at the top
  4. See that there are 8 variables.
  5. View details of m_bps_lod_t1.
  6. See that all cohorts are shown in the harmonisation matrix. [Correct, because this is the 'general' variable explorer and no network/project has been filtered on yet]
  7. Go back to the list of variables.
  8. (if the filter has been deleted (related to bug #2419), repeat steps 3 and 4.)
  9. See that there are 8 variables.
  10. Filter on Athlete project/network on the left hand side.
  11. See that there are still 8 variables in the list.
  12. View details of m_bps_lod_t1.
  13. See that all cohorts are shown in the harmonisation matrix, rather than just the 19 Athlete cohorts, which is what should happen.

Expected behavior A network/project filter in the 'general' variable explorer should work in the same way as when going into the project-specific variable explorer for eg Athlete. Only cohorts in the relevant network should be shown in the harmonisation matrix.

Desktop (please complete the following information):

EleanorHyde-UMCG commented 8 months ago

In SSR this has become irrelevant because in the harmo matrix for all variables, only the cohorts with anything to do with the variable in question are shown. There is no possibility (as yet) to select on a network in the "all variables" variable explorer. If that becomes possible, then it will be necessary to show that only cohorts within the selected network are shown in the harmo matrix.

EleanorHyde-UMCG commented 7 months ago

Let's check this once we have others bugs / features in the variable explorer in SSR sorted out, i.e. when we know whether or not we can select on networks in the 'all variables' variable explorer.