molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
14 stars 16 forks source link

Tables are broken when using refLabel #3699

Closed esthervanenckevort closed 3 weeks ago

esthervanenckevort commented 5 months ago

What version of EMX2 are you using (see footer) v10.63.3-SNAPSHOT

Describe the bug In the tables app the columns that refer to a different entity and use refLabel to construct the value to display are broken, because these fields are no longer fetched after https://github.com/molgenis/molgenis-emx2/pull/3688

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://emx2.dev.molgenis.org/directory-demo/tables/#/Biobanks'
  2. See an error in the head, contact, also known in columns

Expected behavior The fields necessary for the refLabel are fetched and the ref label is shown.

Screenshots

Screenshot 2024-05-02 at 14 58 16
mswertz commented 5 months ago

To be discussed: Might be that with the 'JIT' disable we can up the expandLevel to '1' again and then you would be saved. Also, you could make sure that these fields are part of a 'key' because all key are still included, or that there is a computed field that has key= enabled.

mswertz commented 3 months ago

Can you test again @esthervanenckevort . We have reverted this issue

esthervanenckevort commented 3 weeks ago

Has been resolved