fix: 3517 open external link in new tabs

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.

GNU Lesser General Public License v3.0

11 stars 16 forks source link

Closed connoratrug closed 1 month ago

connoratrug commented 1 month ago

Closes #3517

What are the main changes you did:

Check if document is local file or url , if local show download link , if external show external link and open in new tab

how to test:

todo:

[ ] updated docs in case of new feature
[ ] added/updated tests
[ ] added/updated testplan to include a test for this fix, including ref to bug using # notation

EleanorHyde-UMCG commented 1 month ago

The document does now open in a new window, thanks. Only this has nothing to do with #3794, but more #3517, I think?

EleanorHyde-UMCG commented 1 month ago

(I checked again and yes it does still work on my machine. Odd that it doesn't on yours, @chinook25?)

mswertz commented 1 month ago

please run the formatter

sonarcloud[bot] commented 1 month ago

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication