molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
11 stars 16 forks source link

feat: show matching items when searching #3804

Closed chinook25 closed 1 month ago

chinook25 commented 1 month ago

What are the main changes you did:

how to test:

todo:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

dtroelofsprins commented 1 month ago

Oh bit stupid of me, I suddenly get it, that's of course because a child can have multiple parents and I selected one of his other ones.

konstantina-gkp commented 1 month ago

When searching for the word "iron"in the diagnosis filter, the filter returns all the fields matching the search term. However, the filter also retrieves unrelated diagnoses, such as "environmental", as illustrated in the image below.

search_diagnosis_filter

Shouldn't the search functionality be more specific to avoid such results?

chinook25 commented 1 month ago

When searching for the word "iron"in the diagnosis filter, the filter returns all the fields matching the search term. However, the filter also retrieves unrelated diagnoses, such as "environmental", as illustrated in the image below.

search_diagnosis_filter

Shouldn't the search functionality be more specific to avoid such results?

Maybe, but that's out of the scope of this PR. If we want that, a new feature request should be made :)

dtroelofsprins commented 1 month ago

I agree, and there is already an issue which relates to this: #3558