Closed konstantina-gkp closed 1 month ago
Overall it looks good, but found some issues:
- See code comments
- There appears to be a white bar under the footers if you scroll down, which is not present at master (see https://emx2.dev.molgenis.org/directory-demo/directory/#/catalogue)
- The newsletter button is white, which doens't look great (in the example it's gray).
- Might want to add a `target="__blank" to outgoing links so they open in a new tab
The white bar issue is not present on the dev mode and my local branch is up to date.
I will wait for Esther's reply regarding the styling.
All the already existing links open in the same tab. I simply followed that.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
fixes: #3621 What are the main changes you did:
how to test: