search

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
11 stars 16 forks source link

fix(catalogue): not all the cohorts for current network are shown in harmonisation status per cohorts #3868

Open EleanorHyde-UMCG opened 3 weeks ago

EleanorHyde-UMCG commented 3 weeks ago

What version of EMX2 are you using (see footer) v10.79.3-SNAPSHOT

Describe the bug All the cohorts of the network in question should be shown on the individual variable page of a variable in a network, regardless of whether they have mappings or not.

Recreate the bug

  1. Go to the list of variables for testnetwork1: https://data-catalogue-acc.molgeniscloud.org/testCatalogue/ssr-catalogue/testNetwork1/variables
  2. Click on testVarRepeats.
  3. In the 'harmonisation status' block, all the repeats are shown with their mappings to the cohorts. Testcohort2 should be shown here because this matrix shows all the cohorts of the network in question with their mappings (fully, partially, NA). Leaving testcohort2 out here is incorrect.

Screenshots image

Desktop (please complete the following information): OS: windows 10 Browser Chrome

EleanorHyde-UMCG commented 2 weeks ago

Comment from @marijevdgeest: with variables without repeats you don't get a matrix but a list of cohorts followed by a block of information per cohort. Within networks you can have many, many cohorts. For a variable with few mappings, this could mean lots of redundant information on the page. Is this acceptable?

EleanorHyde-UMCG commented 2 weeks ago

The individual variable page navigated to from within 'All variables' (with 'ALL > VARIABLES' at the top of the page) should only show the cohort(s) with a mapping. There is no network to take into consideration and therefore no list of cohorts to include yes/no, other than what has a mapping.

EleanorHyde-UMCG commented 2 weeks ago

19.6.24 we have decided to leave this AS IS for now. Later we will design and functionality allowing the user to decide whether s/he wants to see "no data" situations but for now we will leave this.