molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
11 stars 16 forks source link

feat(pyclient): upload method for the Pyclient #3881

Open YpeZ opened 2 weeks ago

YpeZ commented 2 weeks ago

What are the main changes you did:

how to test:

todo:

dtroelofsprins commented 6 days ago

Tested CSV upload by using the UI:

With the Pyclient for both files "add/update metadata success" is returned, but in both cases nothing is actually uploaded.

dtroelofsprins commented 6 days ago

Just had a talk with Morris about this: Using the csv like this is not going to work for "tablename".csv's For this some backend changes are needed. As this takes some time, making upload of csv files possible would be to zip the file(s) and then use zip API. Which might be a good idea anyway as this makes data loads smaller.

YpeZ commented 1 day ago

@dtroelofsprins

Tested CSV upload by using the UI:

* a datatable.csv works and returns "imported number of rows: 3"

* upload of molgenis.csv also works returns: "add/update metadata success"

With the Pyclient for both files "add/update metadata success" is returned, but in both cases nothing is actually uploaded.

I have fixed the issue where the molgenis.csv is not actually updated. I also fixed the upload of data from for example Data table.csv. This requires however that a table named Data table exists on the schema, or else the NoSuchTableException is raised. Lastly, I added the recommendation to zip the files first when multiple csv's are to be uploaded.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud