molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
11 stars 16 forks source link

Directory: country filter should not allow 'match all' #3892

Open esthervanenckevort opened 1 week ago

esthervanenckevort commented 1 week ago

What version of EMX2 are you using (see footer) v10.82.0

Describe the bug In the Directory app you can select 'match all' on the country filter, even though this attribute of the biobank is of type 'Ref' and can only ever contain one value.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://directory-emx2-acc.molgenis.net'
  2. Click on 'Countries'

Expected behaviour The drop down list does not have a match all / match any option

Actual behaviour The drop down list does have a match all / match any option. Selecting match all with 2 or more countries selected will always lead to no results

Context You should be able to derive from the metadata whether showing a match all / match any toggle is appropriate. This is only appropriate for 1:n or n:n relationships (ref_array, ontology_array)