molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
11 stars 16 forks source link

feat: add publications to cohort detail, with minimal layout #3903

Closed connoratrug closed 4 days ago

connoratrug commented 1 week ago

What are the main changes you did:

Closes #3894

how to test:

todo:

connoratrug commented 1 week ago
  • put title left and doi right

  • make doi clickable to go to its outside source so I can go the paper "my mind it could all be generated."

due to these kinds of requests we need more data to generate, there is a trade off

N.B. I oberve this code to be very duplicative, while in my mind it could all be generated. So in a future version of catalogue

I want to change that. Now changes to data model become unnecessarily expensive. For now I accept that.

Please suggest a change, we could generate each ref from the backend but this would not allow for 'small' context specific changes ( as requested here) without extending the meta data and increasing page load times ( unless we add caching)

imo these changes should not be part of this feature request

connoratrug commented 5 days ago

the table does not allow for links as the rows are onHover and onClick , a implemented an alternative ui re-using doc card, we can later add more ui/design if needed

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud