molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
14 stars 16 forks source link

fix(directory): number of samples in fact table rows when "Split by" is unchecked in at least one dimension and asterisks are used #3970

Closed sasurfer closed 2 months ago

sasurfer commented 3 months ago

This issue is the direct extension of 3969 to fact that have asterisks in their dimensions. We want to make disappear asterisks when at least one "Split by" is unchecked and have the number of samples fixed.

What version of EMX2 are you using (see footer) v10.88.2

Describe the bug The number of samples is incorrect when asterisks are involved and "Split by" is disabled in at least one dimension. As said before we want also to make disappear asterisks when "Split by" is unchecked.

To Reproduce Steps to reproduce the behavior:

  1. Create a local instance of EMX2
  2. Load the ontologies containing also *
  3. select * on all dimensions. The result is 620 samples for biobank 76823
  4. Now uncheck "Split by" in all columns.
  5. Leaves all for all the dimensions. The result provided is 3720 which is incorrect. It is 6 times the correct one due to asterisks.

Expected behavior We want the sums to be correctly performed and the asterisks to disappear when "Split by" is unchecked in at least one dimension.

Screenshots 4 3

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.