search

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
14 stars 16 forks source link

fix(directory): bookmarkable URL fails #4121

Closed esthervanenckevort closed 6 days ago

esthervanenckevort commented 1 month ago

What version of EMX2 are you using (see footer) v10.106.4

Describe the bug Error when opening a bookmarked URL searching for country=AT and Diagnosis available=icd:II (Neoplasms)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://directory.bbmri-eric.eu/ERIC/'
  2. Click on 'country' and select Austria
  3. Click on 'diagnosis available' and select 'II Neoplasms'
  4. Copy the URL and paste it in a new browser window
  5. App gets stuck with a spinner and there is an error in the console

Expected behavior The app restores the search state.

Screenshots

Screenshot 2024-08-12 at 10 29 21
mswertz commented 1 month ago

We noticed it fails in safari 17.6 but worked in 17.4.1.

However we also notice that all children are selected, is that necessary? if this is an issue with query expansion than that will become another story. But the 'invalid character is weird'. And more importantly, the error should be reported and not lead to endless spinner.

connoratrug commented 6 days ago

can not reproduce

esthervanenckevort commented 6 days ago

Issue is still present in the specific Safari version mentioned (17.6 latest version at this moment). I discovered that Safari will not copy the entire URL if you copy it from the address bar, but it does work from the share sheet (mail URL, bookmark, etc). So I closed this issue since this is a Safari issue.