search

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.
GNU Lesser General Public License v3.0
14 stars 18 forks source link

Upon signing in, I am redirected to the landing page #4479

Closed BrendaHijmans closed 1 week ago

BrendaHijmans commented 2 weeks ago

v11.28.0

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://data-catalogue.molgeniscloud.org/
  2. Click onMore > Upload data
  3. You ar redirected to https://data-catalogue.molgeniscloud.org/apps/central/#/
  4. Sign in via oidc
  5. See error: You are redirected to the landing page of the catalogue after signing in

Expected behavior I want to stay on the page where I signed in

connoratrug commented 2 weeks ago

@harmbrugge could this be a side effect of the update to Javalin ?, i remember we discussed returning to the page were signin flow started during the review. see: f04e886625ae3ced36bed5ba346527bfe48dd758 , fix could be something like https://github.com/molgenis/molgenis-emx2/pull/4481 , or maybe it needs to be an action in the new api style , something lin : https://github.com/molgenis/molgenis-emx2/pull/4482

harmbrugge commented 1 week ago

@connoratrug I think both solutions #4481 and #4482 have the issue we fixed using our own CustomHttpActionHandler. This will cause the redirection action to be triggered without executing our own login logic

connoratrug commented 1 week ago

@connoratrug I think both solutions #4481 and #4482 have the issue we fixed using our own CustomHttpActionHandler. This will cause the redirection action to be triggered without executing our own login logic

did you try the solution ?