chore: auto-formatting - Githubissues

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.

GNU Lesser General Public License v3.0

14 stars 18 forks source link

chore: auto-formatting #4503

Closed svandenhoek closed 1 week ago

svandenhoek commented 1 week ago

What are the main changes you did

Included formatting automatically done when building.

How to test

explain here what to do to test this (or point to unit tests)

Checklist

[ ] updated docs in case of new feature
[ ] added/updated tests
[ ] added/updated testplan to include a test for this fix, including ref to bug using # notation

svandenhoek commented 1 week ago

@connoratrug agreed. While I haven't worked on the graphql code yet myself, I do gotta be honest that I do not have the pre-commit hook either because it really slows down making a commit (I simply make sure I always build once before merging though technically that's not a 100% guarantee as that's something that you could forget to do).

Maybe CI should simply fail if formatting detects needed changes or CI doing this automatically and adds a commit to the branch/master?