Delete schema does not remove schema from other sessions

molgenis / molgenis-emx2

MOLGENIS EMX2, the latest version of the MOLGENIS data platform.

GNU Lesser General Public License v3.0

13 stars 16 forks source link

Delete schema does not remove schema from other sessions #625

Open connoratrug opened 2 years ago

connoratrug commented 2 years ago

What version of EMX2 are you using (see footer) 8.19.0 Describe the bug When 2 users have a session and one deletes a schema that schema still is listed in the other users session.

To Reproduce Steps to reproduce the behavior: sign in with 2 users have one use delete a schema

Expected behavior after page refresh the removed schema should be removed ( for all sessions)

joerivandervelde commented 2 years ago

The same problem also occurs for 1 user when creating a new table with the Java API. (i.e. schema.create(table)) for Software version: 8.62.2. Database version: 4.

What happens:

curl cmdline action triggers a table create (within a schema for which anonymous is OWNER)
table is not shown to anonymous when refreshing (even after calling .schemaChanged() / .clearCache() etc)
log in as different user, e.g. admin
table is now visible for admin
table is now also visible for anonymous

mswertz commented 1 year ago

ah, this is a bug. There is supposed to be a cleaning step that requires all sessions to reload their metadata, see https://github.com/molgenis/molgenis-emx2/blob/master/backend/molgenis-emx2-webapi/src/main/java/org/molgenis/emx2/web/MolgenisSessionManagerDatabaseListener.java so I would start debugging there