search

molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

questionnaires has different vue version than forms #239

Open fdlk opened 6 years ago

fdlk commented 6 years ago

How to Reproduce

Build molgenis-questionnaires

Expected behavior

Versions match

Observed behavior

[ERROR] warning "@molgenis/molgenis-ui-form@0.10.2" has incorrect peer dependency "vue@2.5.13".

If I read it correctly, questionnaires has vue 2.5.15 while forms are still on 2.5.13

fdlk commented 6 years ago

Talked with @ConnorStroomberg and we think it can be solved in the forms library. Forms have too specific a peer dependency, should not be 2.5.13 but something like 2.5.x.

mswertz commented 6 years ago

I would expect versions not to have to match exactly.

sidohaakma commented 6 years ago

Fixed by molgenis/molgenis#7651