search

molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

Inputs are very slow in large forms #248

Open tommydeboer opened 9 years ago

tommydeboer commented 9 years ago

To reproduce:

  1. Upload _Chr6_vragen_emxtestimport10 (2).xlsx (see IssueData on Google Drive)
  2. Go to the bottom of the survey
  3. Type 'molgenis' in the text field
  4. Wait
  5. Wait
  6. Wait
  7. Conclude that it's slow

    Extra's:

The problem is way worse in development mode, but still very noticeable in production. Profiled (in development mode) with React.addons.Perf (while typing the word 'molgenis'):

image Wasted time = time spent on components that did not change their rendering in any way.

tommydeboer commented 9 years ago

The performance improves when I remove all the visibility expressions. There are a lot of those in this survey and it might be that they get checked too often (at every key press?). However, even then it still is laggy enough to be bothersome.

fdlk commented 9 years ago

Forms are quite a bit slower in Safari than in Chrome by the way.

mark-de-haan commented 6 years ago

Wontfix: Will be adressed in the VueForms

dennishendriksen commented 4 years ago

Wontfix: Will be adressed in the VueForms

Was it addressed?