search

molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix(data-explorer): Remove spinner on error #563

Closed connoratrug closed 3 years ago

connoratrug commented 3 years ago

Closes #555

Remove the spinner when an error occurs Delete removing spinner in actions, no need to do this, this is handled by the caller

Checklist

connoratrug commented 3 years ago

Spinner keeps spinning of error

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-563.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #563 (bf15e43) into master (23d1261) will increase coverage by 5.8%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #563     +/-   ##
========================================
+ Coverage    90.9%   96.7%   +5.8%     
========================================
  Files         133      53     -80     
  Lines        2915    1216   -1699     
  Branches      390     228    -162     
========================================
- Hits         2651    1177   -1474     
+ Misses        249      39    -210     
+ Partials       15       0     -15
Flag Coverage Δ
unit 96.7% <100.0%> (+5.8%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/data-explorer/src/store/actions.ts 100.0% <ø> (ø)
packages/data-explorer/src/lib/client.ts 100.0% <100.0%> (ø)
packages/security/src/components/MemberAdd.vue
packages/security/src/components/Toast.vue
packages/questionnaires/src/store/getters.js
packages/security/src/store/getters.ts
packages/scripts/src/components/ExecuteButton.vue
...ts-library/src/components/filters/NumberFilter.vue
...-library/src/components/filters/CheckboxFilter.vue
packages/security/src/components/GroupOverview.vue
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23d1261...bf15e43. Read the comment docs.