molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix(data-explorer): Fix refactor issue #571

Closed connoratrug closed 3 years ago

connoratrug commented 3 years ago

Put back 'hasEditSettingsRights' check for settings button

Checklist

connoratrug commented 3 years ago

Fix: put back hasSettingsRights check for toolbar settings btn

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-571.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #571 (403d172) into master (25ed39c) will decrease coverage by 2.3%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #571     +/-   ##
========================================
- Coverage    89.4%   87.1%   -2.4%     
========================================
  Files         132      73     -59     
  Lines        3084    1699   -1385     
  Branches      460     305    -155     
========================================
- Hits         2760    1480   -1280     
+ Misses        321     219    -102     
+ Partials        3       0      -3     
Flag Coverage Δ
unit 87.1% <ø> (-2.4%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/data-explorer/src/views/ToolbarView.vue 100.0% <ø> (ø)
packages/questionnaires/src/store/index.js
packages/scripts/src/views/EditScript.vue
...uestionnaires/src/components/ChapterNavigation.vue
packages/app-manager/src/store/actions.ts
packages/scripts/src/components/ExecuteButton.vue
packages/questionnaires/src/store/getters.js
packages/questionnaires/src/store/actions.js
packages/security/src/store/actions.ts
packages/questionnaires/src/store/mutations.js
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25ed39c...403d172. Read the comment docs.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-571.dev.molgenis.org