jvanveen commented 3 years ago

Checklist

[ ] Functionality works & meets specifications
[ ] Code reviewed
[ ] Code unit/integration/system tested
[ ] User documentation updated
[ ] Conventional commits (squash if needed)
[ ] No warnings during install
[ ] Updated javascript typing

Why?

Less cognitive load
- Automatic code consistency while editing
- CI-enforced codestyle
- Shared code-style based on community presets/best practices
Elimination of dead code

jvanveen commented 3 years ago

Fix lint issues

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-572.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #572 (c279b57) into master (223ecc9) will decrease coverage by 0.8%. The diff coverage is 96.4%.

@@           Coverage Diff            @@
##           master    #572     +/-   ##
========================================
- Coverage    89.4%   88.6%   -0.9%     
========================================
  Files         132      87     -45     
  Lines        3084    2130    -954     
  Branches      435     403     -32     
========================================
- Hits         2760    1889    -871     
+ Misses        321     241     -80     
+ Partials        3       0      -3

Flag	Coverage Δ
unit	`88.6% <96.4%> (-0.9%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s-library/src/components/filters/ActiveFilters.vue	`97.7% <ø> (ø)`
...s-library/src/components/filters/ChangeFilters.vue	`100.0% <ø> (ø)`
...-library/src/components/filters/CheckboxFilter.vue	`97.8% <ø> (ø)`
...-library/src/components/filters/DateTimeFilter.vue	`86.1% <ø> (ø)`
...nts-library/src/components/filters/MultiFilter.vue	`95.5% <ø> (ø)`
...y/src/components/filters/containers/FilterCard.vue	`100.0% <ø> (ø)`
...s-library/src/components/ui/CartSelectionToast.vue	`100.0% <ø> (ø)`
packages/data-explorer/src/App.vue	`100.0% <ø> (ø)`
...ges/data-explorer/src/components/BreadcrumbBar.vue	`100.0% <ø> (ø)`
...s/data-explorer/src/components/ColumnSelection.vue	`100.0% <ø> (ø)`
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 223ecc9...c279b57. Read the comment docs.

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-572.dev.molgenis.org

MaxPostema commented 3 years ago

Nice, looks like some good spring cleaning. 👍

Not completely sure about the alphabetical css. I like to put properties in more meaningful clusters of concern. But i cant argue with the clean look. 😄