molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix(components-library): added container-fluid instead of container c… #578

Closed jelmerveen closed 3 years ago

jelmerveen commented 3 years ago

…lass to toast, to prevent the button going off-screen

Checklist

connoratrug commented 3 years ago

Cart button missing from interface

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-578.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #578 (685fbde) into master (80b129c) will decrease coverage by 0.8%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #578     +/-   ##
========================================
- Coverage    89.4%   88.6%   -0.9%     
========================================
  Files         132      87     -45     
  Lines        3084    2130    -954     
  Branches      460     403     -57     
========================================
- Hits         2760    1889    -871     
+ Misses        321     241     -80     
+ Partials        3       0      -3     
Flag Coverage Δ
unit 88.6% <ø> (-0.9%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s-library/src/components/ui/CartSelectionToast.vue 100.0% <ø> (ø)
packages/questionnaires/src/store/index.js
packages/security/src/store/getters.ts
packages/security/src/components/GroupOverview.vue
...ges/questionnaires/src/pages/QuestionnaireList.vue
packages/scripts/tests/test-schemas.js
...ages/app-manager/src/views/AppManagerContainer.vue
packages/scripts/src/views/ListScripts.vue
packages/security/src/components/MemberDetail.vue
...uestionnaires/src/components/ChapterNavigation.vue
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80b129c...685fbde. Read the comment docs.