molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix: Let toast make room for shopping cart component #581

Closed MaxPostema closed 3 years ago

MaxPostema commented 3 years ago

Checklist

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-581.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #581 (a510b2f) into master (01b002d) will decrease coverage by 2.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #581     +/-   ##
========================================
- Coverage    89.7%   87.6%   -2.1%     
========================================
  Files         138      79     -59     
  Lines        3162    1779   -1383     
  Branches      466     312    -154     
========================================
- Hits         2838    1560   -1278     
+ Misses        321     219    -102     
+ Partials        3       0      -3     
Flag Coverage Δ
unit 87.6% <100.0%> (-2.1%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/data-explorer/src/views/MainView.vue 93.1% <100.0%> (+0.2%) :arrow_up:
...s-library/src/components/filters/ActiveFilters.vue
...s/components-library/src/components/ui/Toaster.vue
...uestionnaires/src/pages/QuestionnaireSubmitted.vue
.../questionnaires/src/pages/QuestionnaireChapter.vue
packages/security/src/store/actions.ts
packages/security/src/components/Toast.vue
packages/app-manager/src/store/actions.ts
...ages/questionnaires/src/components/ChapterList.vue
packages/scripts/src/views/EditScript.vue
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01b002d...a510b2f. Read the comment docs.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-581.dev.molgenis.org