molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

feat(data-explorer): Use code mirror editor as template editor #583

Closed connoratrug closed 3 years ago

connoratrug commented 3 years ago

Checklist

connoratrug commented 3 years ago

Use code editor from forms lib in template editor

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-583.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #583 (4e3a5ef) into master (01b002d) will decrease coverage by 0.7%. The diff coverage is 25.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #583     +/-   ##
========================================
- Coverage    89.7%   88.9%   -0.8%     
========================================
  Files         138      93     -45     
  Lines        3162    2212    -950     
  Branches      466     386     -80     
========================================
- Hits         2838    1968    -870     
+ Misses        321     244     -77     
+ Partials        3       0      -3     
Flag Coverage Δ
unit 88.9% <25.0%> (-0.8%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/data-explorer/src/views/EditDetailTemplate.vue 87.5% <25.0%> (-12.5%) :arrow_down:
packages/scripts/src/views/ListScripts.vue
packages/scripts/src/service/parameterService.ts
packages/scripts/tests/unit/css-stub.js
...es/questionnaires/src/pages/QuestionnaireStart.vue
packages/app-manager/src/components/AppCard.vue
...ages/app-manager/src/views/AppManagerContainer.vue
packages/security/src/service/asyncUtilService.ts
packages/security/src/store/getters.ts
...ges/questionnaires/src/pages/QuestionnaireList.vue
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01b002d...4e3a5ef. Read the comment docs.

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-583.dev.molgenis.org

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-583.dev.molgenis.org