molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix(components-library): don't use @ shortcut #657

Closed fdlk closed 3 years ago

fdlk commented 3 years ago

This breaks in calling apps

Checklist

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-657.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #657 (bff1c8a) into master (b1e3109) will decrease coverage by 3.5%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #657     +/-   ##
========================================
- Coverage    93.3%   89.8%   -3.6%     
========================================
  Files         119     140     +21     
  Lines        3022    3369    +347     
  Branches      459     500     +41     
========================================
+ Hits         2822    3026    +204     
- Misses        197     340    +143     
  Partials        3       3             
Flag Coverage Δ
unit 89.8% <100.0%> (-3.6%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts-library/src/components/filters/MultiFilter.vue 95.8% <100.0%> (ø)
packages/data-explorer/src/routes.ts 91.6% <0.0%> (ø)
...ponents/navigator/NavigatorModalResourceDelete.vue 33.3% <0.0%> (ø)
.../components/navigator/NavigatorActionsTransfer.vue 20.0% <0.0%> (ø)
...rc/components/navigator/NavigatorActionsDelete.vue 25.0% <0.0%> (ø)
...r/src/components/navigator/NavigatorBreadcrumb.vue 100.0% <0.0%> (ø)
...es/data-explorer/src/components/navigator/Jobs.vue 5.8% <0.0%> (ø)
...kages/data-explorer/src/views/SelectLayoutView.vue 100.0% <0.0%> (ø)
packages/data-explorer/src/views/TableView.vue 100.0% <0.0%> (ø)
packages/data-explorer/src/views/FiltersView.vue 52.1% <0.0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1e3109...bff1c8a. Read the comment docs.