molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix(components-library): controlled Pagination #660

Closed fdlk closed 3 years ago

fdlk commented 3 years ago

Remove the data and listeners from Pagination. Replace with computed model prop. Add button classes and test them.

Checklist

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-660.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #660 (dc2d5f5) into master (3d44bf9) will increase coverage by 0.0%. The diff coverage is 92.3%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #660   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files         140     140           
  Lines        3369    3363    -6     
  Branches      500     500           
======================================
- Hits         3026    3022    -4     
+ Misses        340     338    -2     
  Partials        3       3           
Flag Coverage Δ
unit 89.8% <92.3%> (+<0.1%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents-library/src/components/ui/Pagination.vue 94.2% <92.3%> (+4.0%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d44bf9...dc2d5f5. Read the comment docs.