molgenis / molgenis-frontend

Frontend code for MOLGENIS
GNU Lesser General Public License v3.0
6 stars 12 forks source link

fix: newValues was empty array, which was always truthy and led to error on join #688

Closed jelmerveen closed 3 years ago

jelmerveen commented 3 years ago

Checklist

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-688.dev.molgenis.org

codecov[bot] commented 3 years ago

Codecov Report

Merging #688 (737ca8d) into master (968b90a) will increase coverage by 0.1%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #688     +/-   ##
========================================
+ Coverage    89.5%   89.6%   +0.1%     
========================================
  Files         140     140             
  Lines        3390    3391      +1     
  Branches      504     475     -29     
========================================
+ Hits         3035    3040      +5     
+ Misses        352     348      -4     
  Partials        3       3             
Flag Coverage Δ
unit 89.6% <100.0%> (+0.1%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts-library/src/components/filters/MultiFilter.vue 93.4% <100.0%> (+4.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 968b90a...737ca8d. Read the comment docs.

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-688.dev.molgenis.org

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-688.dev.molgenis.org

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

molgenis-jenkins commented 3 years ago

:star: PR Preview available on https://preview-frontend-pr-688.dev.molgenis.org