molgenis / molgenis-js-rsql

RSQL javascript tools for transforming, encoding and parsing of strings to RSQL and vice versa
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Transform empty-string argument #11

Closed PoffM closed 5 years ago

PoffM commented 5 years ago

Added extra case to convert an empty-string argument to valid RSQL empty string.

Fixes #10

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #11 into master will increase coverage by 1.7%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #11     +/-   ##
========================================
+ Coverage    94.8%   96.6%   +1.7%     
========================================
  Files           1       1             
  Lines          58      59      +1     
  Branches       11      12      +1     
========================================
+ Hits           55      57      +2     
+ Misses          3       2      -1
Flag Coverage Δ
#unit 96.6% <100%> (+1.7%) :arrow_up:
Impacted Files Coverage Δ
src/rsql.js 96.6% <100%> (+1.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f390da8...fad55a6. Read the comment docs.

PoffM commented 5 years ago

Thanks for the quick response! Though I think your 0.1.2 build/publish failed :(