search

molgenis / molgenis-legacy

The MOLGENIS Software generator tool for creating Dynamic Software Infrastructure used in the Life Sciences
http://www.molgenis.org
20 stars 19 forks source link

Delete records in the list view mode of molgenis forms deletes the wrong records! #221

Closed paraiko closed 11 years ago

paraiko commented 11 years ago

The screenshot serie below shows what happens if you want to delete a single record using listmode view in the observed value table Wurkromte 1_011 Wurkromte 1_012

Something is deleted because the total number of records (outside the filter) is decreased by 2. The selected record is not deleted trying to delete it again results in screenshots below.

Wurkromte 1_009 Wurkromte 1_013

The same can happen if you try to delete a range of records without a filter being present. deleting works correct if you browse by page and complete pages are present, but if you skip to the last page and the count is different from the display size than the same "random" delete behaviour occurs.

mswertz commented 11 years ago

To make sure.

Do you evidence that the 'delete' button deletes the wrong record (i.e. the ID underneath the delete is another ID than actually shown)?

Or is this only a bug in the view, i.e. not showing what should be shown.

This difference is a huge diffference in priority of this bug.

M

On Thu, Apr 18, 2013 at 8:46 AM, A.S. Boerema notifications@github.comwrote:

The screenshot serie below shows what happens if you want to delete a single record using listmode view in the observed value table [image: Wurkromte 1_011]https://f.cloud.github.com/assets/1861138/395367/f656c020-a7fa-11e2-9bac-1b0fd1e46705.png [image: Wurkromte 1_013]https://f.cloud.github.com/assets/1861138/395366/f658a534-a7fa-11e2-90ab-315d92ebf619.png

Something is deleted because the total number of records (outside the filter) is decreased by 2. The selected record is not deleted trying to delete it again results in screenshots below.

[image: Wurkromte 1_012]https://f.cloud.github.com/assets/1861138/395365/f6533324-a7fa-11e2-842d-8482acbd19b0.png [image: Wurkromte 1_009]https://f.cloud.github.com/assets/1861138/395364/f629c9a8-a7fa-11e2-977f-bf8e767f5a30.png

This suggests to me that somewhere an array has the wrong offset or something?

The same happens by the way if you try to delete a range of records without a filter being present. If you delete record in the record view it is correctly deleted.

— Reply to this email directly or view it on GitHubhttps://github.com/molgenis/molgenis-legacy/issues/221 .

dennishendriksen commented 11 years ago

I suspect that this bug is related to the issue reported by georgebyelas. I can't find the issue in the tracker so I will forward the e-mail bug report to paraiko and ask georgebyelas to create an issue

paraiko commented 11 years ago

I've checked (in a smaller dataset) that there are actual records missing, So it is not just a bug in the view.

mswertz commented 11 years ago

Okay. Then this has become high prio.

On Thu, Apr 18, 2013 at 12:58 PM, A.S. Boerema notifications@github.comwrote:

I've checked (in a smaller dataset) that there are actual records missing, So it is not just a bug in the view.

— Reply to this email directly or view it on GitHubhttps://github.com/molgenis/molgenis-legacy/issues/221#issuecomment-16572329 .

RoanKanninga commented 11 years ago

bug is fixed. The number separator (numbers > 1000) is the same as the separator we use in a list. Therefore deleting a record with id=30122 is actually deleting records with id=30 and id=122. The fix is that the id and the offset are now without the number separator.