search

molgenis / molgenis-py-consensus

GNU Lesser General Public License v3.0
0 stars 3 forks source link

Missing requirements in README prerequisites #10

Open dennishendriksen opened 3 years ago

dennishendriksen commented 3 years ago

Opening the project in PyCharm shows the following notification: image

pandas, nose and parameterized are not listed in the README prerequisites.

In https://github.com/molgenis/capice/ the Python library requirements are listed in requirements.txt. Would that be useful for this repository as well? We recently ran into issue https://github.com/molgenis/capice/issues/4 which makes me wonder if version numbers should be specified for pandas, nose and parameterized as well?

marikaris commented 3 years ago

The requirements can be found here: https://github.com/molgenis/molgenis-py-consensus/blob/af2d2ba99edde59020920f01463016d4af971702/setup.py#L6 and here: https://github.com/molgenis/molgenis-py-consensus/blob/af2d2ba99edde59020920f01463016d4af971702/setup.py#L10 That's the place I would look for them. If that isn't sufficient, I can add them to a requirements.txt, but it wouldn't be the first place for me to look.

I agree about the version numbers. I will look into that.