molgenis / molgenis-py-consensus

GNU Lesser General Public License v3.0
0 stars 3 forks source link

Fix/history wrong variants #8

Closed marikaris closed 3 years ago

marikaris commented 4 years ago

Some variants were incorrectly presented: https://github.com/molgenis/data-transform-vkgl/issues/14 By fixing this issue, the history of those variants is lost. To fix this as much as possible, we try and find variants with the same gene,c_dna, and transcript to connect the history to the actual variant. For variants that don't have this information, we accept that history is lost. The variants were incorrect and don't make any sense, so we want to keep them out of our database. Variants with incorrect names found in previous exports, will be written to a csv file with a nice message. This file can be used to write a script that puts a note in the comments of the invalid variants in the history table telling that the variant is invalid and the id of the correct variant in future releases.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information