search

molgenis / molgenis-r-datashield

Armadillo implementation of DSI to be DataSHIELD ready, part of the MOLGENIS suite
https://molgenis.github.io/molgenis-r-datashield/
0 stars 3 forks source link

feat: implement DSI 1.2 methods #43

Closed fdlk closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #43 (c4e0264) into master (35afcc4) will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #43   +/-   ##
======================================
  Coverage    97.3%   97.4%           
======================================
  Files           5       5           
  Lines         225     233    +8     
======================================
+ Hits          219     227    +8     
  Misses          6       6
Impacted Files Coverage Δ
R/ArmadilloConnection.R 98.4% <100.0%> (+<0.1%) :arrow_up:
R/ArmadilloResult.R 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ddb4bb...c4e0264. Read the comment docs.

molgenis-jenkins commented 3 years ago

vignettes/pre-render.R:4:1: style: Lines should not be more than 80 characters.

​# you can not use 'fig.path' because the path is used in the <img> tag which then refers to the relative path you type in
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vignettes/pre-render.R:5:1: style: Lines should not be more than 80 characters.

​knitr::knit("vignettes/DSMolgenisArmadillo.Rmd.orig", output = "vignettes/DSMolgenisArmadillo.Rmd")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vignettes/pre-render.R:6:1: style: Lines should not be more than 80 characters.

​knitr::knit("vignettes/development.Rmd.orig", output = "vignettes/development.Rmd")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vignettes/pre-render.R:7:1: style: Lines should not be more than 80 characters.

​knitr::knit("vignettes/workspaces.Rmd.orig", output = "vignettes/workspaces.Rmd")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~