molgenis / molgenis-ui-context

The menu component of MOLGENIS
GNU Lesser General Public License v3.0
0 stars 7 forks source link

fix/navbar bootstrap #114

Closed fdlk closed 3 years ago

fdlk commented 3 years ago

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #114 (a7e4a72) into master (b773c57) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #114   +/-   ##
======================================
  Coverage    93.0%   93.0%           
======================================
  Files          18      18           
  Lines         144     144           
  Branches       20      19    -1     
======================================
  Hits          134     134           
  Misses         10      10           
Flag Coverage Δ
unit 93.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/NavBar.vue 82.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b773c57...a7e4a72. Read the comment docs.

fdlk commented 3 years ago

Depends on https://github.com/molgenis/molgenis-theme/pull/53, otherwise the select box is hidden. To preview, set the bootstrap theme URL in index.html or in the theme manager to https://zen-chandrasekhar-e7bd44.netlify.app/@molgenis-ui/molgenis-theme/dist/mg-molgenis-blue-4.css

Schermafbeelding 2021-01-18 om 16 03 50

molgenis-jenkins commented 3 years ago

:tada: This PR is included in version 1.6.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: