molgenis / molgenis-ui-context

The menu component of MOLGENIS
GNU Lesser General Public License v3.0
0 stars 7 forks source link

Fix/sub menu render #23

Closed ConnorStroomberg closed 5 years ago

ConnorStroomberg commented 5 years ago

Fix #22

Molgenis issue: Menu entries incorrectly displayed in submenu for plugins using Vue header #6728

Style submenus …

Explored a alternative version using js to change the style prop attribute using vue, but i prefer this solution ( using js to generate classes, and styling the classes) as it better allows for styling/theme-ing, and seems more descriptive and semantic to me.

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #23   +/-   ##
====================================
  Coverage      70%   70%           
====================================
  Files           4     4           
  Lines          30    30           
  Branches        7     7           
====================================
  Hits           21    21           
  Misses          9     9
Flag Coverage Δ
#unit 70% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
src/components/DropDownItems.vue 100% <ø> (ø) :arrow_up:
src/exampleMenu.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bbd758...8b9d431. Read the comment docs.

molgenis-jenkins commented 5 years ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: