Closed marikaris closed 5 years ago
Merging #44 into master will increase coverage by
2.1%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #44 +/- ##
========================================
+ Coverage 87.3% 89.4% +2.1%
========================================
Files 11 11
Lines 95 95
Branches 14 14
========================================
+ Hits 83 85 +2
+ Misses 12 10 -2
Flag | Coverage Δ | |
---|---|---|
#unit | 89.4% <ø> (+2.1%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
src/components/NavBar.vue | 84.6% <ø> (+5.1%) |
:arrow_up: |
src/exampleMenu.ts | 100% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ec23fcb...cfc52a6. Read the comment docs.
Merging #44 into master will increase coverage by
2.1%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #44 +/- ##
========================================
+ Coverage 87.3% 89.4% +2.1%
========================================
Files 11 11
Lines 95 95
Branches 14 14
========================================
+ Hits 83 85 +2
+ Misses 12 10 -2
Flag | Coverage Δ | |
---|---|---|
#unit | 89.4% <ø> (+2.1%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
src/components/NavBar.vue | 84.6% <ø> (+5.1%) |
:arrow_up: |
src/exampleMenu.ts | 100% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ec23fcb...f3e1415. Read the comment docs.
:tada: This PR is included in version 1.1.2 :tada:
The release is available on:
npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:
Copy paste issue, the image above navbar was forgotten when the code moved. Added a test for the logo above menu bar, to make sure the issue won't occur again since we had many issues with this feature. Also added a max width to fix another issue (https://github.com/molgenis/molgenis/issues/8430) that was already present in the old menu as well.
Fixes: molgenis/molgenis#8422
Checklist